[PATCH] [libcxxabi] Make _Unwind_Backtrace() work on ARM.

Jonathan Roelofs jonathan at codesourcery.com
Sun Sep 7 14:57:47 PDT 2014



On 9/7/14, 2:23 PM, Nico Weber wrote:
> On Wed, Sep 3, 2014 at 6:25 AM, Jonathan Roelofs <jonathan at codesourcery.com
> <mailto:jonathan at codesourcery.com>> wrote:
>
>
>
>     On 9/3/14, 5:09 AM, Renato Golin wrote:
>
>         On 3 September 2014 01:02, Antoine Labour <piman at google.com
>         <mailto:piman at google.com>> wrote:
>
>             Where in the EHABI spec is that defined? AFAICT all it says in
>             section 6.2
>             is that there's data for the PR, but it doesn't say anything about the
>             contents of that data.
>
>
>         I concur. The EHABI doesn't define what's in the personality data
>         block, let alone that the length must be the first byte. I think these
>         are premature assumptions.
>
>     Hmm, re-reading those sections, I see that it doesn't. I suppose all that
>     can be done is to check that the prel31 points at __gxx_personality_v0, and
>     fail to unwind otherwise.
>
>
> Did this happen? If not, should we back out the change until someone has time to
> implement this correctly?

Not yet. I'll implement it at some point tomorrow, and send it here for review. 
This was already broken before this patch, so I'm not so worried about backing 
it out.


Jon

>
>
>
>
>     Jon
>
>
>         cheers,
>         --renato
>         _________________________________________________
>         cfe-commits mailing list
>         cfe-commits at cs.uiuc.edu <mailto:cfe-commits at cs.uiuc.edu>
>         http://lists.cs.uiuc.edu/__mailman/listinfo/cfe-commits
>         <http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits>
>
>     _________________________________________________
>     cfe-commits mailing list
>     cfe-commits at cs.uiuc.edu <mailto:cfe-commits at cs.uiuc.edu>
>     http://lists.cs.uiuc.edu/__mailman/listinfo/cfe-commits
>     <http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits>
>
>

-- 
Jon Roelofs
jonathan at codesourcery.com
CodeSourcery / Mentor Embedded



More information about the cfe-commits mailing list