[patch] Make "C++98 requires an accessible copy constructor" warning DefaultIgnore

Nico Weber thakis at chromium.org
Sat Sep 6 16:05:57 PDT 2014


Hi,

the attached (tiny) patch changes the ""C++98 requires an accessible copy
constructor" warning to be DefaultIgnore, like e.g. "commas at the end of
enumerator lists are incompatible with C++98" is. The reasoning is that
this construct is accepted by all compilers and valid in C++11, so it
doesn't seem like a useful warning to have enabled by default. Building
with -pedantic, -Wbind-to-temporary-copy, or -Wc++98-compat still shows the
warning.

The motivation is that I built re2, and this was the only warning that was
emitted during the build. Both changing re2 to fix the warning and
detecting clang and suppressing the warning in re2's build seem inferior
than just giving the compiler a good default for this warning.

Ok?

Nico
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140906/d67feced/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: clang-bind-to-temp.patch
Type: application/octet-stream
Size: 2220 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140906/d67feced/attachment.obj>


More information about the cfe-commits mailing list