[PATCH] Call powerpc-darwin external tools with -arch ppc

[Rafael Espíndola]

Committed as r216687. Sorry for the delay, this was lost in my mail box.

On 26 July 2014 09:08, Iain Sandoe <iain at codesourcery.com> wrote:
> Hi Rafael, Stephen,
>
> On 25 Jul 2014, at 20:40, Rafael Espíndola wrote:
>
>> On 25 July 2014 04:32, Stephen Drake <steve at synergyconsultingnz.com> wrote:
>>> Hi Rafael,
>>>
>>> Thanks for having a look at this.  I've updated my patch to add some tests to Driver/darwin-arch-default.c, which I hope is an appropriate place for them.
>>>
>>> After posting the initial patch, I had a go at resolving the FIXME code instead of just copy-pasting it.  I'm also attaching the resulting alternative patch that uses getDefaultUniversalArchName() instead of getArchName() as the starting point for MachO::getMachOArchName().  Having checked the history, I don't think that I'm subverting the intent of either function, but since I'm both an LLVM and C++ noob, it could use some fairly strenuous scrutiny.  In particular, I changed the return type of getDefaultUniversalArchName() from std::string to StringRef, and I'm not sure if that's allowed.
>>
>> The change to use StringRef is a nice independent improvement. I have
>> committed it as r213964 .
>>
>> The code itself looks fine. Ian, can you confirm that this is the
>> right thing to do for darwin powerpc?
>
> LGTM,
>
> @Stephen - perhaps you were just on a FIXME hunt ;)
> - but if you have an interest in contributing more ppc-darwin stuff I'd welcome a "cc" on mails (also David Fang has an interest), and it might be worth dropping into #llvm-powerpc-darwin on irc to discuss, because we have quite a bit of work in progress, would be a shame to duplicate.
>
> thanks for the patch,
> Iain
>