r216558 - Allow __fp16 as a function arg or return type for AArch64

Jiangning Liu liujiangning1 at gmail.com
Wed Aug 27 22:13:07 PDT 2014


Hi Oliver,

Here comes a small test case reproducing the failure.

$ cat bb.c
      float32x4_t result;
      arg1 = vcombine_f16(vcreate_f16(UINT64_C(0x3f0aa8903edf40f8)),
                          vcreate_f16(UINT64_C(0x3f614f463e8b06ca)));
      result = vreinterpretq_f32_f16(arg1);
}
$ clang -O0 -target arm64-linux-gnueabi -c bb.c
fatal error: error in backend: Cannot select: 0x29bf1f8: v4f32 = bitcast
0x29be608 [ORD=34] [ID=25]
  0x29be608: v8f16 = concat_vectors 0x29be3f8, 0x29bc300 [ORD=27] [ID=24]
    0x29be3f8: v4f16,ch = load 0x29bded0, 0x29bdfd8,
0x29bb7a8<LD8[%__p0.addr.i6]> [ORD=25] [ID=23]
      0x29bdfd8: i64 = FrameIndex<2> [ID=8]
      0x29bb7a8: i64 = undef [ID=3]
    0x29bc300: v4f16 = bitcast 0x29bbee0 [ORD=20] [ID=17]
      0x29bbee0: i64 = Constant<4567018660245997258> [ID=5]
In function: dotests_2970
clang-3.5: error: clang frontend command failed with exit code 70 (use -v
to see invocation)
clang version 3.6.0 (216557)
Target: arm64--linux-gnueabi
Thread model: posix
clang-3.5: note: diagnostic msg: PLEASE submit a bug report to
http://llvm.org/bugs/ and include the crash backtrace, preprocessed source,
and associated run script.
clang-3.5: note: diagnostic msg:
********************

PLEASE ATTACH THE FOLLOWING FILES TO THE BUG REPORT:
Preprocessed source(s) and associated run script(s) are located at:
clang-3.5: note: diagnostic msg: /tmp/bb-a66a58.c
clang-3.5: note: diagnostic msg: /tmp/bb-a66a58.sh
clang-3.5: note: diagnostic msg:

********************

Thanks,
-Jiangning



2014-08-28 12:53 GMT+08:00 Jiangning Liu <liujiangning1 at gmail.com>:

> This commit triggered assertion failure
>
> fatal error: error in backend: Cannot select: 0xd785e58: v4f32 = bitcast
> 0xcca5910 [ORD=59] [ID=45]
>   0xcca5910: v8f16,ch = load 0xc1d09d0, 0xbfff270, 0xc1be168<LD16[%arg1]>
> [ORD=56] [ID=44]
>     0xbfff270: i64 = FrameIndex<9> [ID=15]
>     0xc1be168: i64 = undef [ID=3]
> In function: dotests_2970
> clang-3.6: error: clang frontend command failed with exit code 70 (use -v
> to see invocation)
> clang version 3.6.0 (216641)
> Target: arm64--linux-gnueabi
> Thread model: posix
> clang-3.6: note: diagnostic msg: PLEASE submit a bug report to
> http://llvm.org/bugs/ and include the crash backtrace, preprocessed
> source, and associated run script.
>
> And this is blocking our regression test.
>
> Thanks,
> -Jiangning
>
>
> 2014-08-28 0:31 GMT+08:00 Oliver Stannard <oliver.stannard at arm.com>:
>
> Author: olista01
>> Date: Wed Aug 27 11:31:57 2014
>> New Revision: 216558
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=216558&view=rev
>> Log:
>> Allow __fp16 as a function arg or return type for AArch64
>>
>> ACLE 2.0 allows __fp16 to be used as a function argument or return
>> type. This enables this for AArch64.
>>
>> This also fixes an existing bug that causes clang to not allow
>> homogeneous floating-point aggregates with a base type of __fp16. This
>> is valid for AAPCS64, but not for AAPCS-VFP.
>>
>>
>> Modified:
>>     cfe/trunk/include/clang/Basic/LangOptions.def
>>     cfe/trunk/include/clang/Driver/CC1Options.td
>>     cfe/trunk/lib/CodeGen/CGExprConstant.cpp
>>     cfe/trunk/lib/CodeGen/CGExprScalar.cpp
>>     cfe/trunk/lib/CodeGen/CodeGenTypes.cpp
>>     cfe/trunk/lib/CodeGen/TargetInfo.cpp
>>     cfe/trunk/lib/Driver/Tools.cpp
>>     cfe/trunk/lib/Frontend/CompilerInvocation.cpp
>>     cfe/trunk/lib/Sema/SemaType.cpp
>>     cfe/trunk/test/CodeGen/arm64-aapcs-arguments.c
>>
>> Modified: cfe/trunk/include/clang/Basic/LangOptions.def
>> URL:
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/LangOptions.def?rev=216558&r1=216557&r2=216558&view=diff
>>
>> ==============================================================================
>> --- cfe/trunk/include/clang/Basic/LangOptions.def (original)
>> +++ cfe/trunk/include/clang/Basic/LangOptions.def Wed Aug 27 11:31:57 2014
>> @@ -128,6 +128,7 @@ LANGOPT(ShortEnums        , 1, 0, "short
>>  LANGOPT(OpenCL            , 1, 0, "OpenCL")
>>  LANGOPT(OpenCLVersion     , 32, 0, "OpenCL version")
>>  LANGOPT(NativeHalfType    , 1, 0, "Native half type support")
>> +LANGOPT(HalfArgsAndReturns, 1, 0, "half args and returns")
>>  LANGOPT(CUDA              , 1, 0, "CUDA")
>>  LANGOPT(OpenMP            , 1, 0, "OpenMP support")
>>
>>
>> Modified: cfe/trunk/include/clang/Driver/CC1Options.td
>> URL:
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Driver/CC1Options.td?rev=216558&r1=216557&r2=216558&view=diff
>>
>> ==============================================================================
>> --- cfe/trunk/include/clang/Driver/CC1Options.td (original)
>> +++ cfe/trunk/include/clang/Driver/CC1Options.td Wed Aug 27 11:31:57 2014
>> @@ -511,6 +511,8 @@ def vtordisp_mode_EQ : Joined<["-"], "vt
>>    HelpText<"Control vtordisp placement on win32 targets">;
>>  def fno_rtti_data : Flag<["-"], "fno-rtti-data">,
>>    HelpText<"Control emission of RTTI data">;
>> +def fallow_half_arguments_and_returns : Flag<["-"],
>> "fallow-half-arguments-and-returns">,
>> +  HelpText<"Allow function arguments and returns of type half">;
>>
>>
>>  //===----------------------------------------------------------------------===//
>>  // Header Search Options
>>
>> Modified: cfe/trunk/lib/CodeGen/CGExprConstant.cpp
>> URL:
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGExprConstant.cpp?rev=216558&r1=216557&r2=216558&view=diff
>>
>> ==============================================================================
>> --- cfe/trunk/lib/CodeGen/CGExprConstant.cpp (original)
>> +++ cfe/trunk/lib/CodeGen/CGExprConstant.cpp Wed Aug 27 11:31:57 2014
>> @@ -1132,7 +1132,8 @@ llvm::Constant *CodeGenModule::EmitConst
>>    case APValue::Float: {
>>      const llvm::APFloat &Init = Value.getFloat();
>>      if (&Init.getSemantics() == &llvm::APFloat::IEEEhalf &&
>> -         !Context.getLangOpts().NativeHalfType)
>> +        !Context.getLangOpts().NativeHalfType &&
>> +        !Context.getLangOpts().HalfArgsAndReturns)
>>        return llvm::ConstantInt::get(VMContext, Init.bitcastToAPInt());
>>      else
>>        return llvm::ConstantFP::get(VMContext, Init);
>>
>> Modified: cfe/trunk/lib/CodeGen/CGExprScalar.cpp
>> URL:
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGExprScalar.cpp?rev=216558&r1=216557&r2=216558&view=diff
>>
>> ==============================================================================
>> --- cfe/trunk/lib/CodeGen/CGExprScalar.cpp (original)
>> +++ cfe/trunk/lib/CodeGen/CGExprScalar.cpp Wed Aug 27 11:31:57 2014
>> @@ -701,7 +701,8 @@ Value *ScalarExprEmitter::EmitScalarConv
>>    llvm::Type *SrcTy = Src->getType();
>>
>>    // If casting to/from storage-only half FP, use special intrinsics.
>> -  if (SrcType->isHalfType() &&
>> !CGF.getContext().getLangOpts().NativeHalfType) {
>> +  if (SrcType->isHalfType() &&
>> !CGF.getContext().getLangOpts().NativeHalfType &&
>> +      !CGF.getContext().getLangOpts().HalfArgsAndReturns) {
>>      Src = Builder.CreateCall(
>>          CGF.CGM.getIntrinsic(llvm::Intrinsic::convert_from_fp16,
>>                               CGF.CGM.FloatTy),
>> @@ -773,7 +774,8 @@ Value *ScalarExprEmitter::EmitScalarConv
>>                               DstTy);
>>
>>    // Cast to half via float
>> -  if (DstType->isHalfType() &&
>> !CGF.getContext().getLangOpts().NativeHalfType)
>> +  if (DstType->isHalfType() &&
>> !CGF.getContext().getLangOpts().NativeHalfType &&
>> +      !CGF.getContext().getLangOpts().HalfArgsAndReturns)
>>      DstTy = CGF.FloatTy;
>>
>>    if (isa<llvm::IntegerType>(SrcTy)) {
>> @@ -1691,7 +1693,8 @@ ScalarExprEmitter::EmitScalarPrePostIncD
>>      // Add the inc/dec to the real part.
>>      llvm::Value *amt;
>>
>> -    if (type->isHalfType() &&
>> !CGF.getContext().getLangOpts().NativeHalfType) {
>> +    if (type->isHalfType() &&
>> !CGF.getContext().getLangOpts().NativeHalfType &&
>> +        !CGF.getContext().getLangOpts().HalfArgsAndReturns) {
>>        // Another special case: half FP increment should be done via float
>>        value = Builder.CreateCall(
>>            CGF.CGM.getIntrinsic(llvm::Intrinsic::convert_from_fp16,
>> @@ -1714,7 +1717,8 @@ ScalarExprEmitter::EmitScalarPrePostIncD
>>      }
>>      value = Builder.CreateFAdd(value, amt, isInc ? "inc" : "dec");
>>
>> -    if (type->isHalfType() &&
>> !CGF.getContext().getLangOpts().NativeHalfType)
>> +    if (type->isHalfType() &&
>> !CGF.getContext().getLangOpts().NativeHalfType &&
>> +        !CGF.getContext().getLangOpts().HalfArgsAndReturns)
>>        value = Builder.CreateCall(
>>            CGF.CGM.getIntrinsic(llvm::Intrinsic::convert_to_fp16,
>>                                 CGF.CGM.FloatTy),
>>
>> Modified: cfe/trunk/lib/CodeGen/CodeGenTypes.cpp
>> URL:
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CodeGenTypes.cpp?rev=216558&r1=216557&r2=216558&view=diff
>>
>> ==============================================================================
>> --- cfe/trunk/lib/CodeGen/CodeGenTypes.cpp (original)
>> +++ cfe/trunk/lib/CodeGen/CodeGenTypes.cpp Wed Aug 27 11:31:57 2014
>> @@ -358,9 +358,10 @@ llvm::Type *CodeGenTypes::ConvertType(Qu
>>
>>      case BuiltinType::Half:
>>        // Half FP can either be storage-only (lowered to i16) or native.
>> -      ResultType = getTypeForFormat(getLLVMContext(),
>> -          Context.getFloatTypeSemantics(T),
>> -          Context.getLangOpts().NativeHalfType);
>> +      ResultType =
>> +          getTypeForFormat(getLLVMContext(),
>> Context.getFloatTypeSemantics(T),
>> +                           Context.getLangOpts().NativeHalfType ||
>> +                               Context.getLangOpts().HalfArgsAndReturns);
>>        break;
>>      case BuiltinType::Float:
>>      case BuiltinType::Double:
>>
>> Modified: cfe/trunk/lib/CodeGen/TargetInfo.cpp
>> URL:
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/TargetInfo.cpp?rev=216558&r1=216557&r2=216558&view=diff
>>
>> ==============================================================================
>> --- cfe/trunk/lib/CodeGen/TargetInfo.cpp (original)
>> +++ cfe/trunk/lib/CodeGen/TargetInfo.cpp Wed Aug 27 11:31:57 2014
>> @@ -3544,8 +3544,9 @@ public:
>>  };
>>  }
>>
>> -static bool isHomogeneousAggregate(QualType Ty, const Type *&Base,
>> +static bool isARMHomogeneousAggregate(QualType Ty, const Type *&Base,
>>                                     ASTContext &Context,
>> +                                   bool isAArch64,
>>                                     uint64_t *HAMembers = nullptr);
>>
>>  ABIArgInfo AArch64ABIInfo::classifyArgumentType(QualType Ty,
>> @@ -3627,7 +3628,7 @@ ABIArgInfo AArch64ABIInfo::classifyArgum
>>    // Homogeneous Floating-point Aggregates (HFAs) need to be expanded.
>>    const Type *Base = nullptr;
>>    uint64_t Members = 0;
>> -  if (isHomogeneousAggregate(Ty, Base, getContext(), &Members)) {
>> +  if (isARMHomogeneousAggregate(Ty, Base, getContext(), true, &Members))
>> {
>>      IsHA = true;
>>      if (!IsNamedArg && isDarwinPCS()) {
>>        // With the Darwin ABI, variadic arguments are always passed on
>> the stack
>> @@ -3685,7 +3686,7 @@ ABIArgInfo AArch64ABIInfo::classifyRetur
>>      return ABIArgInfo::getIgnore();
>>
>>    const Type *Base = nullptr;
>> -  if (isHomogeneousAggregate(RetTy, Base, getContext()))
>> +  if (isARMHomogeneousAggregate(RetTy, Base, getContext(), true))
>>      // Homogeneous Floating-point Aggregates (HFAs) are returned
>> directly.
>>      return ABIArgInfo::getDirect();
>>
>> @@ -3822,7 +3823,7 @@ static llvm::Value *EmitAArch64VAArg(llv
>>
>>    const Type *Base = nullptr;
>>    uint64_t NumMembers;
>> -  bool IsHFA = isHomogeneousAggregate(Ty, Base, Ctx, &NumMembers);
>> +  bool IsHFA = isARMHomogeneousAggregate(Ty, Base, Ctx, true,
>> &NumMembers);
>>    if (IsHFA && NumMembers > 1) {
>>      // Homogeneous aggregates passed in registers will have their
>> elements split
>>      // and stored 16-bytes apart regardless of size (they're notionally
>> in qN,
>> @@ -3965,7 +3966,7 @@ llvm::Value *AArch64ABIInfo::EmitDarwinV
>>    uint64_t Align = CGF.getContext().getTypeAlign(Ty) / 8;
>>
>>    const Type *Base = nullptr;
>> -  bool isHA = isHomogeneousAggregate(Ty, Base, getContext());
>> +  bool isHA = isARMHomogeneousAggregate(Ty, Base, getContext(), true);
>>
>>    bool isIndirect = false;
>>    // Arguments bigger than 16 bytes which aren't homogeneous aggregates
>> should
>> @@ -4251,15 +4252,16 @@ void ARMABIInfo::setRuntimeCC() {
>>      RuntimeCC = abiCC;
>>  }
>>
>> -/// isHomogeneousAggregate - Return true if a type is an AAPCS-VFP
>> homogeneous
>> +/// isARMHomogeneousAggregate - Return true if a type is an AAPCS-VFP
>> homogeneous
>>  /// aggregate.  If HAMembers is non-null, the number of base elements
>>  /// contained in the type is returned through it; this is used for the
>>  /// recursive calls that check aggregate component types.
>> -static bool isHomogeneousAggregate(QualType Ty, const Type *&Base,
>> -                                   ASTContext &Context, uint64_t
>> *HAMembers) {
>> +static bool isARMHomogeneousAggregate(QualType Ty, const Type *&Base,
>> +                                   ASTContext &Context, bool isAArch64,
>> +                                   uint64_t *HAMembers) {
>>    uint64_t Members = 0;
>>    if (const ConstantArrayType *AT = Context.getAsConstantArrayType(Ty)) {
>> -    if (!isHomogeneousAggregate(AT->getElementType(), Base, Context,
>> &Members))
>> +    if (!isARMHomogeneousAggregate(AT->getElementType(), Base, Context,
>> isAArch64, &Members))
>>        return false;
>>      Members *= AT->getSize().getZExtValue();
>>    } else if (const RecordType *RT = Ty->getAs<RecordType>()) {
>> @@ -4270,7 +4272,7 @@ static bool isHomogeneousAggregate(QualT
>>      Members = 0;
>>      for (const auto *FD : RD->fields()) {
>>        uint64_t FldMembers;
>> -      if (!isHomogeneousAggregate(FD->getType(), Base, Context,
>> &FldMembers))
>> +      if (!isARMHomogeneousAggregate(FD->getType(), Base, Context,
>> isAArch64, &FldMembers))
>>          return false;
>>
>>        Members = (RD->isUnion() ?
>> @@ -4284,12 +4286,22 @@ static bool isHomogeneousAggregate(QualT
>>      }
>>
>>      // Homogeneous aggregates for AAPCS-VFP must have base types of
>> float,
>> -    // double, or 64-bit or 128-bit vectors.
>> +    // double, or 64-bit or 128-bit vectors. "long double" has the same
>> machine
>> +    // type as double, so it is also allowed as a base type.
>> +    // Homogeneous aggregates for AAPCS64 must have base types of a
>> floating
>> +    // point type or a short-vector type. This is the same as the 32-bit
>> ABI,
>> +    // but with the difference that any floating-point type is allowed,
>> +    // including __fp16.
>>      if (const BuiltinType *BT = Ty->getAs<BuiltinType>()) {
>> -      if (BT->getKind() != BuiltinType::Float &&
>> -          BT->getKind() != BuiltinType::Double &&
>> -          BT->getKind() != BuiltinType::LongDouble)
>> -        return false;
>> +      if (isAArch64) {
>> +        if (!BT->isFloatingPoint())
>> +          return false;
>> +      } else {
>> +        if (BT->getKind() != BuiltinType::Float &&
>> +            BT->getKind() != BuiltinType::Double &&
>> +            BT->getKind() != BuiltinType::LongDouble)
>> +          return false;
>> +      }
>>      } else if (const VectorType *VT = Ty->getAs<VectorType>()) {
>>        unsigned VecSize = Context.getTypeSize(VT);
>>        if (VecSize != 64 && VecSize != 128)
>> @@ -4491,7 +4503,7 @@ ABIArgInfo ARMABIInfo::classifyArgumentT
>>      // into VFP registers.
>>      const Type *Base = nullptr;
>>      uint64_t Members = 0;
>> -    if (isHomogeneousAggregate(Ty, Base, getContext(), &Members)) {
>> +    if (isARMHomogeneousAggregate(Ty, Base, getContext(), false,
>> &Members)) {
>>        assert(Base && "Base class should be set for homogeneous
>> aggregate");
>>        // Base can be a floating-point or a vector.
>>        if (Base->isVectorType()) {
>> @@ -4696,7 +4708,7 @@ ABIArgInfo ARMABIInfo::classifyReturnTyp
>>    // Check for homogeneous aggregates with AAPCS-VFP.
>>    if (getABIKind() == AAPCS_VFP && !isVariadic) {
>>      const Type *Base = nullptr;
>> -    if (isHomogeneousAggregate(RetTy, Base, getContext())) {
>> +    if (isARMHomogeneousAggregate(RetTy, Base, getContext(), false)) {
>>        assert(Base && "Base class should be set for homogeneous
>> aggregate");
>>        // Homogeneous Aggregates are returned directly.
>>        return ABIArgInfo::getDirect(nullptr, 0, nullptr, !isAAPCS_VFP);
>>
>> Modified: cfe/trunk/lib/Driver/Tools.cpp
>> URL:
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/Tools.cpp?rev=216558&r1=216557&r2=216558&view=diff
>>
>> ==============================================================================
>> --- cfe/trunk/lib/Driver/Tools.cpp (original)
>> +++ cfe/trunk/lib/Driver/Tools.cpp Wed Aug 27 11:31:57 2014
>> @@ -3714,6 +3714,10 @@ void Clang::ConstructJob(Compilation &C,
>>      CmdArgs.push_back(Args.MakeArgString("-mstack-alignment=" +
>> alignment));
>>    }
>>
>> +  if (getToolChain().getTriple().getArch() == llvm::Triple::aarch64 ||
>> +      getToolChain().getTriple().getArch() == llvm::Triple::aarch64_be)
>> +    CmdArgs.push_back("-fallow-half-arguments-and-returns");
>> +
>>    if (Arg *A = Args.getLastArg(options::OPT_mrestrict_it,
>>                                 options::OPT_mno_restrict_it)) {
>>      if (A->getOption().matches(options::OPT_mrestrict_it)) {
>>
>> Modified: cfe/trunk/lib/Frontend/CompilerInvocation.cpp
>> URL:
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Frontend/CompilerInvocation.cpp?rev=216558&r1=216557&r2=216558&view=diff
>>
>> ==============================================================================
>> --- cfe/trunk/lib/Frontend/CompilerInvocation.cpp (original)
>> +++ cfe/trunk/lib/Frontend/CompilerInvocation.cpp Wed Aug 27 11:31:57 2014
>> @@ -1500,6 +1500,8 @@ static void ParseLangArgs(LangOptions &O
>>    Opts.CurrentModule = Args.getLastArgValue(OPT_fmodule_name);
>>    Opts.ImplementationOfModule =
>>        Args.getLastArgValue(OPT_fmodule_implementation_of);
>> +  Opts.NativeHalfType = Opts.NativeHalfType;
>> +  Opts.HalfArgsAndReturns =
>> Args.hasArg(OPT_fallow_half_arguments_and_returns);
>>
>>    if (!Opts.CurrentModule.empty() &&
>> !Opts.ImplementationOfModule.empty() &&
>>        Opts.CurrentModule != Opts.ImplementationOfModule) {
>>
>> Modified: cfe/trunk/lib/Sema/SemaType.cpp
>> URL:
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaType.cpp?rev=216558&r1=216557&r2=216558&view=diff
>>
>> ==============================================================================
>> --- cfe/trunk/lib/Sema/SemaType.cpp (original)
>> +++ cfe/trunk/lib/Sema/SemaType.cpp Wed Aug 27 11:31:57 2014
>> @@ -1746,7 +1746,7 @@ bool Sema::CheckFunctionReturnType(QualT
>>    }
>>
>>    // Functions cannot return half FP.
>> -  if (T->isHalfType()) {
>> +  if (T->isHalfType() && !getLangOpts().HalfArgsAndReturns) {
>>      Diag(Loc, diag::err_parameters_retval_cannot_have_fp16_type) << 1 <<
>>        FixItHint::CreateInsertion(Loc, "*");
>>      return true;
>> @@ -1776,7 +1776,7 @@ QualType Sema::BuildFunctionType(QualTyp
>>      if (ParamType->isVoidType()) {
>>        Diag(Loc, diag::err_param_with_void_type);
>>        Invalid = true;
>> -    } else if (ParamType->isHalfType()) {
>> +    } else if (ParamType->isHalfType() &&
>> !getLangOpts().HalfArgsAndReturns) {
>>        // Disallow half FP arguments.
>>        Diag(Loc, diag::err_parameters_retval_cannot_have_fp16_type) << 0
>> <<
>>          FixItHint::CreateInsertion(Loc, "*");
>> @@ -2751,7 +2751,7 @@ static TypeSourceInfo *GetFullTypeForDec
>>              S.Diag(D.getIdentifierLoc(), diag::err_opencl_half_return)
>> << T;
>>              D.setInvalidType(true);
>>            }
>> -        } else {
>> +        } else if (!S.getLangOpts().HalfArgsAndReturns) {
>>            S.Diag(D.getIdentifierLoc(),
>>              diag::err_parameters_retval_cannot_have_fp16_type) << 1;
>>            D.setInvalidType(true);
>> @@ -2941,7 +2941,7 @@ static TypeSourceInfo *GetFullTypeForDec
>>                  D.setInvalidType();
>>                  Param->setInvalidDecl();
>>                }
>> -            } else {
>> +            } else if (!S.getLangOpts().HalfArgsAndReturns) {
>>                S.Diag(Param->getLocation(),
>>                  diag::err_parameters_retval_cannot_have_fp16_type) << 0;
>>                D.setInvalidType();
>>
>> Modified: cfe/trunk/test/CodeGen/arm64-aapcs-arguments.c
>> URL:
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/arm64-aapcs-arguments.c?rev=216558&r1=216557&r2=216558&view=diff
>>
>> ==============================================================================
>> --- cfe/trunk/test/CodeGen/arm64-aapcs-arguments.c (original)
>> +++ cfe/trunk/test/CodeGen/arm64-aapcs-arguments.c Wed Aug 27 11:31:57
>> 2014
>> @@ -1,4 +1,4 @@
>> -// RUN: %clang_cc1 -triple arm64-linux-gnu -target-feature +neon
>> -target-abi aapcs -ffreestanding -emit-llvm -w -o - %s | FileCheck %s
>> +// RUN: %clang_cc1 -triple aarch64-linux-gnu -target-feature +neon
>> -target-abi aapcs -ffreestanding -fallow-half-arguments-and-returns
>> -emit-llvm -w -o - %s | FileCheck %s
>>
>>  // AAPCS clause C.8 says: If the argument has an alignment of 16 then
>> the NGRN
>>  // is rounded up to the next even number.
>> @@ -40,3 +40,12 @@ void test4(BigHFA v0_v2, BigHFA v3_v5, B
>>  // CHECK: define i8 @test5(i8 %a, i16 %b)
>>  unsigned char test5(unsigned char a, signed short b) {
>>  }
>> +
>> +// __fp16 can be used as a function argument or return type (ACLE 2.0)
>> +// CHECK: define half @test_half(half %{{.*}})
>> +__fp16 test_half(__fp16 A) { }
>> +
>> +// __fp16 is a base type for homogeneous floating-point aggregates for
>> AArch64 (but not 32-bit ARM).
>> +// CHECK: define %struct.HFA_half @test_half_hfa(half %{{.*}}, half
>> %{{.*}}, half %{{.*}}, half %{{.*}})
>> +struct HFA_half { __fp16 a[4]; };
>> +struct HFA_half test_half_hfa(struct HFA_half A) { }
>>
>>
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140828/a5434122/attachment.html>


More information about the cfe-commits mailing list