[libcxx] r216317 - Add return statement to a test class's assignment operator. Defect found by Coverity Scan.

Justin Bogner mail at justinbogner.com
Tue Aug 26 18:36:59 PDT 2014


Eric Fiselier <eric at efcs.ca> writes:
> I'm not opposed to the change but using Filecheck really hurts our ability to
> test standalone.
> Also, we don't have that many compilation failures tests. I'm not sure how
> badly this change is needed.

Using clang -verify avoids that issue, but there's still the matter of
having to update almost 300 tests to use it.

Here's a quick example of hackily adding a verify flag instead of
checking for rc 1 in the lit.cfg and updating the test under discussion:

-------------- next part --------------
A non-text attachment was scrubbed...
Name: libcxx-verify.patch
Type: text/x-patch
Size: 1514 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140826/3c0cddc4/attachment.bin>


More information about the cfe-commits mailing list