r216469 - c11- Check for c11 language option as documentation says

[jahanian]

On Aug 26, 2014, at 2:07 PM, Jordan Rose <jordan_rose at apple.com> wrote:

> 
> On Aug 26, 2014, at 13:15 , Richard Smith <richard at metafoo.co.uk> wrote:
> 
>> On Tue, Aug 26, 2014 at 11:13 AM, Fariborz Jahanian <fjahanian at apple.com> wrote:
>> Author: fjahanian
>> Date: Tue Aug 26 13:13:47 2014
>> New Revision: 216469
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=216469&view=rev
>> Log:
>> c11- Check for c11 language option as documentation says
>> feature is c11 about nested struct declarations must have
>> struct-declarator-list. Without this change, code
>> which was meant for c99 breaks. rdar://18125536
>> 
>> This change does not look correct; the same rule existed in C89 and C99 too (but it was enforced by the grammar in those languages). [Additionally, your commit message is a bit garbled, you didn't add a new test case, and the only other information you provide is a link to an Apple-internal bug, so I'm not even sure what problem you're trying to fix.]
>>  
> 
> Shoot, I'm sorry. Richard is right—this rule does fall out of the grammar, so the original code is (technically) illegal in C99.

Thanks Jordan for clarifying. I then revert the patch and ask project owners to add the warning-compression flag (or modify their code).
- Fariborz

> 
> Jordan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140826/f25f1e3f/attachment.html>