r216463 - Switching from std::vector to llvm::ArrayRef per post-commit review suggestion.

Will Dietz wdietz2 at uiuc.edu
Tue Aug 26 10:54:32 PDT 2014


Thanks, apologies for the breakage!

I'll review the Coding standards regarding the C++11 changes carefully... :).

~Will

On Tue, Aug 26, 2014 at 12:05 PM, Aaron Ballman <aaron at aaronballman.com> wrote:
> Author: aaronballman
> Date: Tue Aug 26 12:05:57 2014
> New Revision: 216463
>
> URL: http://llvm.org/viewvc/llvm-project?rev=216463&view=rev
> Log:
> Switching from std::vector to llvm::ArrayRef per post-commit review suggestion.
>
> Modified:
>     cfe/trunk/unittests/AST/ASTVectorTest.cpp
>
> Modified: cfe/trunk/unittests/AST/ASTVectorTest.cpp
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/unittests/AST/ASTVectorTest.cpp?rev=216463&r1=216462&r2=216463&view=diff
> ==============================================================================
> --- cfe/trunk/unittests/AST/ASTVectorTest.cpp (original)
> +++ cfe/trunk/unittests/AST/ASTVectorTest.cpp Tue Aug 26 12:05:57 2014
> @@ -18,8 +18,6 @@
>
>  #include "gtest/gtest.h"
>
> -#include <vector>
> -
>  using namespace clang;
>
>  namespace clang {
> @@ -73,7 +71,7 @@ TEST_F(ASTVectorTest, InsertEmpty) {
>
>    // Ensure no pointer overflow when inserting empty range
>    int Values[] = { 0, 1, 2, 3 };
> -  std::vector<int> IntVec(Values, Values + 4);
> +  ArrayRef<int> IntVec(Values);
>    auto I = V.insert(Ctxt, V.begin(), IntVec.begin(), IntVec.begin());
>    ASSERT_EQ(V.begin(), I);
>    ASSERT_TRUE(V.empty());
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits



More information about the cfe-commits mailing list