[PATCH] [libcxx] Get categories.numeric and facet.numpunct localization tests passing on linux

Eric Fiselier eric at efcs.ca
Mon Aug 25 16:37:15 PDT 2014


================
Comment at: test/localization/locale.categories/facet.numpunct/locale.numpunct.byname/thousands_sep.pass.cpp:59
@@ -57,1 +58,3 @@
+        // http://docs.oracle.com/cd/E19455-01/806-0169/overview-9/index.html
+#       if !defined(__GLIBC__)
             assert(np.thousands_sep() == ',');
----------------
mclow.lists wrote:
> My suggestion here is to change the #if from `!defined(__GLIBC__)` to `defined(_APPLE_)` and move on.
> 
> See if that breaks any other systems (FREEBSD, etc).
This test is currently passing on FreeBSD. So I think we should stick with __GLIBC__ in this specific case.

http://llvm-amd64.freebsd.your.org/b/builders/libcxx-amd64-freebsd/builds/507/steps/check-libcxx/logs/stdio

http://reviews.llvm.org/D4997






More information about the cfe-commits mailing list