[libcxx] r216317 - Add return statement to a test class's assignment operator. Defect found by Coverity Scan.
jonathan at codesourcery.com
Sat Aug 23 18:01:31 PDT 2014
On 8/23/14, 6:45 PM, Jonathan Roelofs wrote:
> On 8/23/14, 6:13 PM, Chandler Carruth wrote:
>> On Sat, Aug 23, 2014 at 4:40 PM, Jonathan Roelofs <jonathan at codesourcery.com
>> <mailto:jonathan at codesourcery.com>> wrote:
>> This is a fail test... could it be that the missing return is actually part
>> of the behavior being checked by this test?
>> Unless its testing a compilation failure no, and as it did compile that seems
Really? Check again...
>> You can test for the behavior of falling off the end of a function without a
>> return -- that behavior is undefined, so its impossible to write a test against.
> Oh, right.
Wait a second, this test is *supposed* to be a compile failure, but not for the
reason I originally thought. It's testing that unique_ptr requires the deleter
have a public default constructor. Because it fails to compile, '-Wall -Wextra
-pedantic -Werror' won't help us here :(
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
More information about the cfe-commits