[libcxx] r216317 - Add return statement to a test class's assignment operator. Defect found by Coverity Scan.

Eric Fiselier eric at efcs.ca
Sat Aug 23 00:39:49 PDT 2014


> We have a Clang warning for this - I would like to know why that didn't
catch it? Are we not building this with -Wreturn-type?

Currently we don't compile our tests with any warning flags. I'm not sure
if it was just too noisy but looking at other defects
Coverity found its clear we need to enable at least some of them. There are
a bunch of assignments that should be comparisons as well.

/Eric


On Sat, Aug 23, 2014 at 1:33 AM, Chandler Carruth <chandlerc at google.com>
wrote:

>
> On Fri, Aug 22, 2014 at 11:36 PM, Eric Fiselier <eric at efcs.ca> wrote:
>
>> Add return statement to a test class's assignment operator. Defect found
>> by Coverity Scan.
>>
>
> We have a Clang warning for this - I would like to know why that didn't
> catch it? Are we not building this with -Wreturn-type?
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140823/72c87409/attachment.html>


More information about the cfe-commits mailing list