libc++ atomics test change request

Steve MacKenzie stevemac321 at
Fri Aug 22 16:44:21 PDT 2014


I would like to resume testing MSVC STL using the Libc++ tests.   


Would it be OK to add noexcept specifiers to some of the test structs that
are used as template params to std::atomic?   I believe this change is
benign, so I am hoping you don't care or require conditional blocks.    


Explanation from:


atomic() noexcept = default", so when the default constructor for

std::atomic<T> is invoked for a type T that has a throwing constructor,

the noexcept version is not found, which causes the compiler to emit

an error message about the deleted function. To work around this,

you need to declare the constructor of test_struct as noexcept.


The affected tests pass using:

clang version 3.5.0 (trunk 212120)

Target: x86_64-unknown-linux-gnu

Thread model: posix



Steve MacKenzie



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: atomics-noexcept.txt
URL: <>

More information about the cfe-commits mailing list