[PATCH] Coverage mapping: Don't map implicit casts and modify "ignore if not extended" flag semantics

Alex L arphaman at gmail.com
Fri Aug 22 15:33:08 PDT 2014

It's ensuring that macros like `define N 1024` don't create mapping regions
when the integer literal
is implicitly converted. It also makes sure that literals in ternary
conditional create mapping regions
- e.g. there will be a mapping region for 1 and 0 in `cond? 1 : 0` .

2014-08-20 23:49 GMT-07:00 Justin Bogner <mail at justinbogner.com>:

> Alex L <arphaman at gmail.com> writes:
> > These two patches remove the mapping for implicit cast expression and
> > modify the "ignore if not extended" flag to be "ignore if file only
> > has this region". I'm sending them out together as they both partially
> > influence a common testcase.
> Why? What is this accomplishing? As far as I can tell one of these
> patches removes a CHECK line and the other adds back the exact same
> check. I guess this changes how that particular construct is modelled?
> If so, it might be better to just make this one patch so it's clear that
> you're not removing functionality, but changing how it's done.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140822/1477d0e0/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ignoreImplicitCastAndModifyRegionIgnore.patch
Type: application/octet-stream
Size: 4574 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140822/1477d0e0/attachment.obj>

More information about the cfe-commits mailing list