[PATCH] [analyzer] Remove duplicate test case from MissingDealloc.m

David Kilzer ddkilzer at kilzer.net
Fri Aug 22 12:30:45 PDT 2014


Hi jordan_rose, krememek,

A duplicate test case was added in r64257 that was originally
added in r60720.  Remove it, and clean up trailing whitespace.

http://reviews.llvm.org/D5031

Files:
  test/Analysis/MissingDealloc.m

Index: test/Analysis/MissingDealloc.m
===================================================================
--- test/Analysis/MissingDealloc.m
+++ test/Analysis/MissingDealloc.m
@@ -17,16 +17,18 @@
 //  assignment through the setter does not perform a release.
 
 @interface MyObject : NSObject {
-  id _myproperty;  
+  id _myproperty;
 }
 @property(assign) id myproperty;
 @end
 
 @implementation MyObject
 @synthesize myproperty=_myproperty; // no-warning
 - (void)dealloc {
-  self.myproperty = 0;
-  [super dealloc]; 
+  // Don't claim that myproperty is released since it the property
+  // has the 'assign' attribute.
+  self.myproperty = 0; // no-warning
+  [super dealloc];
 }
 @end
 
@@ -65,27 +67,6 @@
 @end
 
 //===------------------------------------------------------------------------===
-// <rdar://problem/6380411>
-// Was bogus warning: "The '_myproperty' instance variable was not retained by a
-//  synthesized property but was released in 'dealloc'"
-
- at interface MyObject_rdar6380411 : NSObject {
-    id _myproperty;
-}
- at property(assign) id myproperty;
- at end
-
- at implementation MyObject_rdar6380411
- at synthesize myproperty=_myproperty;
-- (void)dealloc {
-    // Don't claim that myproperty is released since it the property
-    // has the 'assign' attribute.
-    self.myproperty = 0; // no-warning
-    [super dealloc];
-}
- at end
-
-//===------------------------------------------------------------------------===
 // PR 3187: http://llvm.org/bugs/show_bug.cgi?id=3187
 // - Disable the missing -dealloc check for classes that subclass SenTestCase
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D5031.12853.patch
Type: text/x-patch
Size: 1574 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140822/2ad5febd/attachment.bin>


More information about the cfe-commits mailing list