[PATCH] Fix PR17239 by changing the semantics of the RemainingArgsClass Option kind (clang side)

Rafael Auler rafaelauler at gmail.com
Fri Aug 22 11:52:04 PDT 2014

Hi Reid,

Sure, thanks for reviewing it. I answered your comment below.

Comment at: tools/driver/driver.cpp:406-409
@@ -391,1 +405,6 @@
+    // Remove markers, if we added them
+    if (MarkEOLs) {
+      auto newEnd = std::remove(argv.begin(), argv.end(), nullptr);
+      argv.resize(newEnd - argv.begin());
+    }
     return ExecuteCC1Tool(argv, argv[1] + 4);
Reid Kleckner wrote:
> This seems impossible. If we invoked a cc1 tool, we shouldn't have added EOL markers, right?
I made this check just in case the user puts "-cc1" as a first argument in a response file. In this case, MarkEOLs would be true. After expanding the response files, we would end up here with MarkEOLs true (a contrived example, but possible).


More information about the cfe-commits mailing list