[PATCH] [libcxx] Get categories.numeric and facet.numpunct localization tests passing on linux

Dan Albert danalbert at google.com
Thu Aug 21 13:50:58 PDT 2014

Comment at: test/localization/locale.categories/category.numeric/locale.nm.put/facet.num.put.members/put_long_double.pass.cpp:10722
@@ -10721,1 +10721,3 @@
     const my_facet f(1);
+#if !defined(__GLIBC__)
Eric Fiselier wrote:
> Eric Fiselier wrote:
> > Dan Albert wrote:
> > > Marshall Clow wrote:
> > > > Are these values mandated by a standard somewhere - or are they just "implementation defined"?
> > > > 
> > > > 
> > > I had previously misread this part of the diff. This looks wrong to me now that I look closer (and with all the context). Specifically, [ul]nan4. That can't be right.
> > I think it follows It seems weird but my reading of the standard does not make it incorrect.
> > I'll look into it some more. The rest of the cases seem reasonable though.
> The disagreement seems to be just about if NAN should have the positive sign. I didn't see anything in the standard but I'll take another look.
Nerver mind. Had misread and didn't realize the fill character was being set to '*'.


More information about the cfe-commits mailing list