r216020 - Test: Coverage Mapping: add missing RUN commands

Alex L arphaman at gmail.com
Wed Aug 20 10:39:22 PDT 2014


Thanks, I applied your suggestion in r216085.


2014-08-20 0:31 GMT-07:00 Justin Bogner <mail at justinbogner.com>:

> Alex Lorenz <arphaman at gmail.com> writes:
> > --- cfe/trunk/test/CoverageMapping/classtemplate.cpp (original)
> > +++ cfe/trunk/test/CoverageMapping/classtemplate.cpp Tue Aug 19 15:51:54
> 2014
> > @@ -1,7 +1,7 @@
> >  // RUN: %clang_cc1 -triple %itanium_abi_triple -fprofile-instr-generate
> -fcoverage-mapping -dump-coverage-mapping -emit-llvm-only -main-file-name
> classtemplate.cpp %s > %tmapping
> > -// cat %tmapping | FileCheck %s --check-prefix=CHECK-CONSTRUCTOR
> > -// cat %tmapping | FileCheck %s --check-prefix=CHECK-GETTER
> > -// cat %tmapping | FileCheck %s --check-prefix=CHECK-SETTER
> > +// RUN: cat %tmapping | FileCheck %s --check-prefix=CHECK-CONSTRUCTOR
> > +// RUN: cat %tmapping | FileCheck %s --check-prefix=CHECK-GETTER
> > +// RUN: cat %tmapping | FileCheck %s --check-prefix=CHECK-SETTER
>
> It's not added by this change, but ``cat | FileCheck`` is a pretty weird
> pattern. Please change these to ``RUN: FileCheck -input-file %tmapping
> ...``
> while you're making changes here.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140820/153df6c3/attachment.html>


More information about the cfe-commits mailing list