[PATCH] Make the analyzer detect more misues of open(2)

Jordan Rose jordan_rose at apple.com
Wed Aug 20 10:07:31 PDT 2014


Nice work! Committed as r216078 and r216079. Thanks, Daniel!

On Aug 18, 2014, at 5:14 , Daniel Fahlgren <daniel at fahlgren.se> wrote:

> Hi,
> 
> These patches makes the unix.API checker detect more errors when using
> open(2). The first is to detect when open is called with more than three
> arguments. The second patch makes sure that the third argument is an
> integer.
> 
> I've added a new test file for these cases. The current one, nix-fns.c,
> does a lot more than simply testing the expected warnings.
> 
> Cheers,
> Daniel Fahlgren
> <0001-Warn-when-open-is-called-with-too-many-arguments.patch><0002-Check-if-open-2-is-called-with-a-valid-mode.patch>




More information about the cfe-commits mailing list