[clang-tools-extra] r215947 - [clang-rename] revert r215839

[Gerolf Hoflehner]

There is nothing special about this particular bot.

- It failed on many bots
- It failed in my local environment

Do you have trouble reproducing it?


Gerolf

On Aug 18, 2014, at 10:21 PM, Manuel Klimek <klimek at google.com> wrote:

> Huh, I thought I had fixed them - do you happen to know what is special about this build-bot? Or did I just misinterpret the other buildbots and need to learn how to read them better?
> 
> Thanks!
> 
> On Mon Aug 18 2014 at 1:16:05 AM Gerolf Hoflehner <ghoflehner at apple.com> wrote:
> Author: ghoflehner
> Date: Mon Aug 18 18:03:30 2014
> New Revision: 215947
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=215947&view=rev
> Log:
> [clang-rename] revert r215839
> 
> The commit broke public build bots for more than 24 hours.
> 
> (view as text)
> ******************** TEST 'Clang Tools :: clang-rename/VarTest.cpp' FAILED ********************
> Script:
> --
> cat /Users/buildslave/zorg/buildbot/smooshlab/slave-0.8/build.clang-x86_64-darwin11-nobootstrap-RAincremental/clang.src/tools/extra/test/clang-rename/VarTest.cpp > /Users/buildslave/zorg/buildbot/smooshlab/slave-0.8/build.clang-x86_64-darwin11-nobootstrap-RAincremental/clang-build/tools/clang/tools/extra/test/clang-rename/Output/VarTest.cpp.tmp.cpp
> clang-rename -offset=$(grep -FUbo 'foo;' /Users/buildslave/zorg/buildbot/smooshlab/slave-0.8/build.clang-x86_64-darwin11-nobootstrap-RAincremental/clang-build/tools/clang/tools/extra/test/clang-rename/Output/VarTest.cpp.tmp.cpp | head -1 | cut -d: -f1) -new-name=hector /Users/buildslave/zorg/buildbot/smooshlab/slave-0.8/build.clang-x86_64-darwin11-nobootstrap-RAincremental/clang-build/tools/clang/tools/extra/test/clang-rename/Output/VarTest.cpp.tmp.cpp -i --
> sed 's,//.*,,' /Users/buildslave/zorg/buildbot/smooshlab/slave-0.8/build.clang-x86_64-darwin11-nobootstrap-RAincremental/clang-build/tools/clang/tools/extra/test/clang-rename/Output/VarTest.cpp.tmp.cpp | FileCheck /Users/buildslave/zorg/buildbot/smooshlab/slave-0.8/build.clang-x86_64-darwin11-nobootstrap-RAincremental/clang.src/tools/extra/test/clang-rename/VarTest.cpp
> --
> Exit Code: 1
> 
> Command Output (stderr):
> --
> clang-rename: could not find symbol at /Users/buildslave/zorg/buildbot/smooshlab/slave-0.8/build.clang-x86_64-darwin11-nobootstrap-RAincremental/clang-build/tools/clang/tools/extra/test/clang-rename/Output/VarTest.cpp.tmp.cpp:2:1 (offset 14).
> 
> 
> Removed:
>     clang-tools-extra/trunk/clang-rename/
>     clang-tools-extra/trunk/test/clang-rename/
>     clang-tools-extra/trunk/unittests/clang-rename/
> Modified:
>     clang-tools-extra/trunk/CMakeLists.txt
>     clang-tools-extra/trunk/Makefile
>     clang-tools-extra/trunk/test/CMakeLists.txt
>     clang-tools-extra/trunk/unittests/CMakeLists.txt
> 
> Modified: clang-tools-extra/trunk/CMakeLists.txt
> URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/CMakeLists.txt?rev=215947&r1=215946&r2=215947&view=diff
> ==============================================================================
> --- clang-tools-extra/trunk/CMakeLists.txt (original)
> +++ clang-tools-extra/trunk/CMakeLists.txt Mon Aug 18 18:03:30 2014
> @@ -1,6 +1,5 @@
>  add_subdirectory(clang-apply-replacements)
>  add_subdirectory(clang-modernize)
> -add_subdirectory(clang-rename)
>  add_subdirectory(modularize)
>  add_subdirectory(module-map-checker)
>  add_subdirectory(remove-cstr-calls)
> 
> Modified: clang-tools-extra/trunk/Makefile
> URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/Makefile?rev=215947&r1=215946&r2=215947&view=diff
> ==============================================================================
> --- clang-tools-extra/trunk/Makefile (original)
> +++ clang-tools-extra/trunk/Makefile Mon Aug 18 18:03:30 2014
> @@ -13,8 +13,8 @@ include $(CLANG_LEVEL)/../../Makefile.co
> 
>  PARALLEL_DIRS := remove-cstr-calls tool-template modularize \
>   module-map-checker pp-trace
> -DIRS := clang-apply-replacements clang-modernize clang-rename clang-tidy \
> -       clang-query unittests
> +DIRS := clang-apply-replacements clang-modernize clang-tidy clang-query \
> +       unittests
> 
>  include $(CLANG_LEVEL)/Makefile
> 
> 
> Modified: clang-tools-extra/trunk/test/CMakeLists.txt
> URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/CMakeLists.txt?rev=215947&r1=215946&r2=215947&view=diff
> ==============================================================================
> --- clang-tools-extra/trunk/test/CMakeLists.txt (original)
> +++ clang-tools-extra/trunk/test/CMakeLists.txt Mon Aug 18 18:03:30 2014
> @@ -37,7 +37,6 @@ set(CLANG_TOOLS_TEST_DEPS
>    # Individual tools we test.
>    clang-apply-replacements
>    clang-modernize
> -  clang-rename
>    clang-query
>    clang-tidy
>    modularize
> 
> Modified: clang-tools-extra/trunk/unittests/CMakeLists.txt
> URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/unittests/CMakeLists.txt?rev=215947&r1=215946&r2=215947&view=diff
> ==============================================================================
> --- clang-tools-extra/trunk/unittests/CMakeLists.txt (original)
> +++ clang-tools-extra/trunk/unittests/CMakeLists.txt Mon Aug 18 18:03:30 2014
> @@ -7,6 +7,5 @@ endfunction()
> 
>  add_subdirectory(clang-apply-replacements)
>  add_subdirectory(clang-modernize)
> -add_subdirectory(clang-rename)
>  add_subdirectory(clang-query)
>  add_subdirectory(clang-tidy)
> 
> 
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140818/83c62b20/attachment.html>