r215791 - Revert "Update for LLVM change (StringSaver)"

Sean Silva chisophugis at gmail.com
Fri Aug 15 16:39:12 PDT 2014


Author: silvas
Date: Fri Aug 15 18:39:12 2014
New Revision: 215791

URL: http://llvm.org/viewvc/llvm-project?rev=215791&view=rev
Log:
Revert "Update for LLVM change (StringSaver)"

This reverts commit r215785 / 170ebf4f19459ae51a9561d0e65c87ee4c9b2c97.

LLD has some StringSavers that need to be updated. One of which takes a
lock and I need to investigate that more closely.

Modified:
    cfe/trunk/tools/driver/driver.cpp

Modified: cfe/trunk/tools/driver/driver.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/tools/driver/driver.cpp?rev=215791&r1=215790&r2=215791&view=diff
==============================================================================
--- cfe/trunk/tools/driver/driver.cpp (original)
+++ cfe/trunk/tools/driver/driver.cpp Fri Aug 15 18:39:12 2014
@@ -41,7 +41,6 @@
 #include "llvm/Support/Program.h"
 #include "llvm/Support/Regex.h"
 #include "llvm/Support/Signals.h"
-#include "llvm/Support/StringSaver.h"
 #include "llvm/Support/TargetRegistry.h"
 #include "llvm/Support/TargetSelect.h"
 #include "llvm/Support/Timer.h"
@@ -282,6 +281,18 @@ static void ParseProgName(SmallVectorImp
   }
 }
 
+namespace {
+  class StringSetSaver : public llvm::cl::StringSaver {
+  public:
+    StringSetSaver(std::set<std::string> &Storage) : Storage(Storage) {}
+    const char *SaveString(const char *Str) override {
+      return GetStableCStr(Storage, Str);
+    }
+  private:
+    std::set<std::string> &Storage;
+  };
+}
+
 static void SetBackdoorDriverOutputsFromEnvVars(Driver &TheDriver) {
   // Handle CC_PRINT_OPTIONS and CC_PRINT_OPTIONS_FILE.
   TheDriver.CCPrintOptions = !!::getenv("CC_PRINT_OPTIONS");
@@ -372,7 +383,7 @@ int main(int argc_, const char **argv_)
   }
 
   std::set<std::string> SavedStrings;
-  llvm::StringSaver Saver;
+  StringSetSaver Saver(SavedStrings);
   llvm::cl::ExpandResponseFiles(Saver, llvm::cl::TokenizeGNUCommandLine, argv);
 
   // Handle -cc1 integrated tools.





More information about the cfe-commits mailing list