[PATCH] CGCall: Factor out the logic mapping call arguments to LLVM IR arguments.

Reid Kleckner rnk at google.com
Fri Aug 15 15:46:25 PDT 2014

Nice! I've contemplated doing a cleanup like this, but it looks like you have succeeded where I have failed.

Comment at: lib/CodeGen/CGCall.cpp:1048
@@ +1047,3 @@
+class CallArgsToIRArgsMapping {
+  const unsigned InvalidIndex = ~0U;
I think we can sink all of this into CGFunctionInfo once we remove the AAPCS issue.  I pinged James Molloy about this.

Comment at: lib/CodeGen/CGCall.cpp:1140
@@ +1139,3 @@
+        // side, so extension should be a non-issue.
+        CGM.getTypes().GetExpandedTypes(ArgType, Types);
+        NumIRArgs = Types.size();
Maybe we can do this once after computing CGFunctionInfo and then store it in CGFunctionInfo?


More information about the cfe-commits mailing list