r215560 - Small cleanup: Don't duplicate default behavior.

Rafael Espindola rafael.espindola at gmail.com
Wed Aug 13 10:08:22 PDT 2014


Author: rafael
Date: Wed Aug 13 12:08:22 2014
New Revision: 215560

URL: http://llvm.org/viewvc/llvm-project?rev=215560&view=rev
Log:
Small cleanup: Don't duplicate default behavior.

std::unique_ptr is null initialized and reset default to null.

Thanks to David Blaikie for noticing.

Modified:
    cfe/trunk/lib/Frontend/ASTUnit.cpp

Modified: cfe/trunk/lib/Frontend/ASTUnit.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Frontend/ASTUnit.cpp?rev=215560&r1=215559&r2=215560&view=diff
==============================================================================
--- cfe/trunk/lib/Frontend/ASTUnit.cpp (original)
+++ cfe/trunk/lib/Frontend/ASTUnit.cpp Wed Aug 13 12:08:22 2014
@@ -219,7 +219,7 @@ ASTUnit::ASTUnit(bool _MainFileIsAST)
     TUKind(TU_Complete), WantTiming(getenv("LIBCLANG_TIMING")),
     OwnsRemappedFileBuffers(true),
     NumStoredDiagnosticsFromDriver(0),
-    PreambleRebuildCounter(0), SavedMainFileBuffer(nullptr),
+    PreambleRebuildCounter(0),
     NumWarningsInPreamble(0),
     ShouldCacheCodeCompletionResults(false),
     IncludeBriefCommentsInCodeCompletion(false), UserFilesAreVolatile(false),
@@ -1026,7 +1026,7 @@ static void checkAndSanitizeDiags(SmallV
 /// \returns True if a failure occurred that causes the ASTUnit not to
 /// contain any translation-unit information, false otherwise.
 bool ASTUnit::Parse(llvm::MemoryBuffer *OverrideMainBuffer) {
-  SavedMainFileBuffer.reset(nullptr);
+  SavedMainFileBuffer.reset();
 
   if (!Invocation) {
     delete OverrideMainBuffer;





More information about the cfe-commits mailing list