Debuginfo: Correctly tag variadic ObjC methods with DW_TAG_unspecified_parameter.

Frédéric Riss friss at apple.com
Mon Aug 11 22:08:54 PDT 2014


Thanks, committed as r215423 with ending “.”s added to the comments.

Fred

> On 11 Aug 2014, at 19:07, Eric Christopher <echristo at gmail.com> wrote:
> 
> Yup. Otherwise, yeah, LGTM.
> 
> -eric
> 
> On Mon, Aug 11, 2014 at 9:19 AM, Adrian Prantl <aprantl at apple.com> wrote:
>> This looks good to me. Some people may complain that comments should always be full sentences and therefore should have a trailing “.” :-)
>> 
>> thanks!
>> adrian
>> 
>>> On Aug 10, 2014, at 11:11 PM, Frédéric Riss <friss at apple.com> wrote:
>>> 
>>> Everything’s in the subject. Ok to apply?
>>> 
>>> <rdar.13690847.diff>
>>> 
>>> Fred
>> 





More information about the cfe-commits mailing list