r215360 - Increase SmallVector<> size in DiagnosticsEngine::setSeverityForGroup
mail at justinbogner.com
Mon Aug 11 15:53:28 PDT 2014
Richard Smith <richard at metafoo.co.uk> writes:
> On Mon, Aug 11, 2014 at 1:54 PM, Hans Wennborg <hans at chromium.org> wrote:
> On Mon, Aug 11, 2014 at 1:28 PM, David Blaikie <dblaikie at gmail.com> wrote:
> > On Mon, Aug 11, 2014 at 9:05 AM, Hans Wennborg <hans at hanshq.net> wrote:
> >> Author: hans
> >> Date: Mon Aug 11 11:05:54 2014
> >> New Revision: 215360
> >> URL: http://llvm.org/viewvc/llvm-project?rev=215360&view=rev
> >> Log:
> >> Increase SmallVector<> size in DiagnosticsEngine::setSeverityForGroup
> >> In a Clang bootstrap, this vector always held 129 elements.
> > Presumably this is because the largest diagnostic group has 129
> > elements. When you say "always held 129 elements" - you mean the
> > maximum for a given compilation was 129? Or on /every/ call it was
> > 129? I'd be surprised if it was the same count on every call.
> It was 129 on every call. Maybe it was only getting called for a
> specific diagnostics group.
> At a guess, your build had only one -W flag, and that group has 129
> diagnostics. Maybe it's -Wall?
I also noticed that the other SmallVectors in Diagnostic.cpp didn't show
up in the data that was sent out. For example, the one in
setDiagnostcGroupErrorAsFatal. I guess this would vary with different -W
and -Werror flags and the like.
More information about the cfe-commits