r215371 - Revert r215365 - Coverage mapping: emit mapping for cxx constructors that use microsoft's ABI

Alex Lorenz arphaman at gmail.com
Mon Aug 11 11:21:34 PDT 2014


Author: arphaman
Date: Mon Aug 11 13:21:34 2014
New Revision: 215371

URL: http://llvm.org/viewvc/llvm-project?rev=215371&view=rev
Log:
Revert r215365 - Coverage mapping: emit mapping for cxx constructors that use microsoft's ABI

Modified:
    cfe/trunk/lib/CodeGen/CodeGenPGO.cpp

Modified: cfe/trunk/lib/CodeGen/CodeGenPGO.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CodeGenPGO.cpp?rev=215371&r1=215370&r2=215371&view=diff
==============================================================================
--- cfe/trunk/lib/CodeGen/CodeGenPGO.cpp (original)
+++ cfe/trunk/lib/CodeGen/CodeGenPGO.cpp Mon Aug 11 13:21:34 2014
@@ -847,13 +847,8 @@ void CodeGenPGO::checkGlobalDecl(GlobalD
   // a class. Every function is instrumented, but we only want to provide
   // coverage for one of them. Because of that we only emit the coverage mapping
   // for the base constructor/destructor.
-  // For Microsoft's C++ ABI Clang emits only the complete constructor,
-  // therefore we have to emit the coverage mapping for it instead of the base
-  // one.
-  const CXXCtorType AcceptedCtor =
-      CGM.getTarget().getCXXABI().isMicrosoft()? Ctor_Complete : Ctor_Base;
   if ((isa<CXXConstructorDecl>(GD.getDecl()) &&
-       GD.getCtorType() != AcceptedCtor) ||
+       GD.getCtorType() != Ctor_Base) ||
       (isa<CXXDestructorDecl>(GD.getDecl()) &&
        GD.getDtorType() != Dtor_Base)) {
     SkipCoverageMapping = true;





More information about the cfe-commits mailing list