[clang-tools-extra] r215152 - [clang-tidy] Implement the include order checker for LLVM.

Alexander Kornienko alexfh at google.com
Fri Aug 8 01:34:19 PDT 2014


On Thu, Aug 7, 2014 at 11:49 PM, Benjamin Kramer <benny.kra at googlemail.com>
wrote:

> ...
> --- clang-tools-extra/trunk/test/clang-tidy/check_clang_tidy_fix.sh
> (original)
> +++ clang-tools-extra/trunk/test/clang-tidy/check_clang_tidy_fix.sh Thu
> Aug  7 16:49:38 2014
> @@ -20,7 +20,7 @@ set -o errexit
>  # Remove the contents of the CHECK lines to avoid CHECKs matching on
> themselves.
>  # We need to keep the comments to preserve line numbers while avoiding
> empty
>  # lines which could potentially trigger formatting-related checks.
> -sed 's#// *[A-Z-]\+:.*#//#' ${INPUT_FILE} > ${TEMPORARY_FILE}
> +sed -E 's#// *[A-Z-]+:.*#//#' ${INPUT_FILE} > ${TEMPORARY_FILE}
>

The check is awesome, but the idea to improve sed invocation turned out to
be not very nice: r215163, r215171, r215175, and finally back to what it
was: r215189. Let's leave it as is ;)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140808/bafc6b6a/attachment.html>


More information about the cfe-commits mailing list