r215047 - Make FullExprArg trivially copyable by removing the copy ctor

Reid Kleckner reid at kleckner.net
Wed Aug 6 18:00:42 PDT 2014


Author: rnk
Date: Wed Aug  6 20:00:42 2014
New Revision: 215047

URL: http://llvm.org/viewvc/llvm-project?rev=215047&view=rev
Log:
Make FullExprArg trivially copyable by removing the copy ctor

The default copy ctor is good.  This avoids using inalloca for a bunch
of Sema methods when self-hosting.

Modified:
    cfe/trunk/include/clang/Sema/Sema.h

Modified: cfe/trunk/include/clang/Sema/Sema.h
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Sema/Sema.h?rev=215047&r1=215046&r2=215047&view=diff
==============================================================================
--- cfe/trunk/include/clang/Sema/Sema.h (original)
+++ cfe/trunk/include/clang/Sema/Sema.h Wed Aug  6 20:00:42 2014
@@ -2946,11 +2946,6 @@ public:
   public:
     FullExprArg(Sema &actions) : E(nullptr) { }
 
-    // FIXME: The const_cast here is ugly. RValue references would make this
-    // much nicer (or we could duplicate a bunch of the move semantics
-    // emulation code from Ownership.h).
-    FullExprArg(const FullExprArg& Other) : E(Other.E) {}
-
     ExprResult release() {
       return E;
     }





More information about the cfe-commits mailing list