r214924 - Make crash diagnostics on Windows the tiniest bit more useful

Yi Kong kongy.dev at gmail.com
Wed Aug 6 17:16:01 PDT 2014


The leading white space isn't meaningful any more. It was necessary
because it was implemented as concatenating string in a loop.

http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/Compilation.cpp?r1=190620&r2=190619&pathrev=190620

Patch LGTM, thanks!

-Yi

On 6 August 2014 23:26, Tobias Grosser <tobias at grosser.es> wrote:
> It seems the reason is that a white space at the beginning of the last line
> of 'clang -v -E -x c /dev/null -###' is not longer emitted, but LNT
> seems to match for exactly this white space. I am not sure if and why
> this white space was there and if it carried some meaning, but in case this
> change on the clang side was intentional, I attached a patch to fix LNT.
>
> Cheers,
> Tobias
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>



More information about the cfe-commits mailing list