Patch to force SuitableAlign's alignment when loading on object with larger alignment

jahanian fjahanian at apple.com
Mon Aug 4 09:32:05 PDT 2014


On Aug 3, 2014, at 10:20 PM, David Majnemer <david.majnemer at gmail.com> wrote:

> On Fri, Aug 1, 2014 at 12:43 PM, Reid Kleckner <rnk at google.com> wrote:
> On Fri, Aug 1, 2014 at 12:14 PM, jahanian <fjahanian at apple.com> wrote:
> 
> On Aug 1, 2014, at 11:44 AM, Reid Kleckner <rnk at google.com> wrote:
> 
>> What is HasAlignAttribute, and how is it different from AlignmentIsRequired? I have a feeling that they are different names for the same thing. If you want to rename it, that's fine with me.
>> 
> 
> I first thought I could use AlignmentIsRequired. But then I noticed that AlignmentIsRequired  is set only if current typedef has explicit
> alignment. (see Decl::getMaxAlignment). We want to make sure that a typedef of an aligned typedef is 
> still considered explicitly aligned (and not to modify its alignment). My patch has a test for this case.
> 
> That sounds like a bug.
> 
> This bug should be fixed in r214698.

Thanks.
- Fariborz


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140804/1ea0b85f/attachment.html>


More information about the cfe-commits mailing list