r214410 - Exposes a C API to name mangling for a given cursor.

Eli Bendersky eliben at google.com
Fri Aug 1 08:10:54 PDT 2014


Rafael, thanks for fixing PR 20127. Committed this patch in r214520.


On Fri, Aug 1, 2014 at 7:21 AM, Eli Bendersky <eliben at google.com> wrote:

>
>
>
> On Fri, Aug 1, 2014 at 6:26 AM, Rafael EspĂ­ndola <
> rafael.espindola at gmail.com> wrote:
>
>> >> With the approach of using the backend mangler, you wouldn't need to
>> >> strip the \01 prefix because the backend mangler does that anyway (see
>> >> lib/IR/Mangler.cpp:105).
>> >>
>> >
>> > Yes, but this is not the path I'm going through - I don't have a LLVM
>> > GlobalValue. The Twine-accepting function doesn't do this stripping. See
>> > http://llvm.org/bugs/show_bug.cgi?id=20127 - I'd be able to simplify
>> this
>> > code when it's fixed.
>>
>> Cool. Nice to have a testcase for the patch in pr20127 :-)
>>
>> Do you want me to apply it first?
>>
>
> Yes, that would be great.
>
> Eli
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140801/102a3110/attachment.html>


More information about the cfe-commits mailing list