[PATCH] Improved source range in nonnull diagnostics

Aaron Ballman aaron at aaronballman.com
Fri Aug 1 06:07:35 PDT 2014


On Thu, Jul 31, 2014 at 5:05 PM, jahanian <fjahanian at apple.com> wrote:
>
> On Jul 31, 2014, at 12:21 PM, Aaron Ballman <aaron at aaronballman.com> wrote:
>
> The attach patch addresses a FIXME asking for improved source range
> information when a nonnull parameter or return type is not a pointer
> type. A few questions come to mind:
>
> 1) Is my addition to ObjCMethodDecl the correct way to get return type
> source range information?
>
>
> LGTM. We use the same in other places.For example, in
> Sema::CheckObjCMethodOverride

Thanks! I've committed in r214507 -- if tests are required, we can
figure those out post-commit.

~Aaron



More information about the cfe-commits mailing list