[PATCH] Support constant expressions, including non-type template parameters, in pragma loop hints

Tyler Nowicki tnowicki at apple.com
Thu Jul 31 09:44:23 PDT 2014


>> -def err_pragma_loop_invalid_value : Error<
>> -  "invalid argument; expected a positive integer value">;
>> +def err_pragma_loop_invalid_argument : Error<
>> +  "invalid argument %0; expected a positive 32-bit integer value">;
> 
> Why is this diagnostic now in Sema and Parser (in the patch attached
> to your latest email)?


I’m not sure whats going on with the patch on the email. It was shorter than the actual file. I’ll try sending it again.

The err_pragma_loop_invalid_argument is used by CheckLoopHintExpr in Sema.

Tyler


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140731/633e66a9/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: loop_hint_constant_expression-svn.patch
Type: application/octet-stream
Size: 44000 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140731/633e66a9/attachment.obj>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140731/633e66a9/attachment-0001.html>


More information about the cfe-commits mailing list