release_35 patches for unroll pragma

Mark Heffernan meheff at google.com
Tue Jul 29 12:35:08 PDT 2014


Hi,

Below are a handful of patches I submitted last week for the loop unroll
pragma which would be nice to get into 3.5.  The bug fix and metadata
renaming ones I'd particularly like to see get in.  The "#pragma nounroll"
is more of a nice-to-have.  All of the patches should only affect code
which uses one of the forms of the loop unroll pragmas.

Rename metadata.  In unroll pragma syntax and loop hint metadata, change
"enable" forms to a new form using the string "full":
r213771 (clang)
r213772 (llvm)
r213775 (fix broken test caused by r213771)

Add support for #pragma nounroll :
r213885

Bug fixes:
r213789 : Do not add unroll disable metadata after unrolling pass for loops
with #pragma clang loop unroll(full).
r213900 : Fix bug where some loops with loop unroll_count(N) would
mistakenly not be unrolled.

Let me know if these are reasonable.

Thanks!
Mark
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140729/4ae36df9/attachment.html>


More information about the cfe-commits mailing list