[PATCH v3 4/9] Have TypoCorrectionConsumer remember the TypoCorrections it returned.

Richard Smith richard at metafoo.co.uk
Fri Jul 25 14:01:18 PDT 2014


+  TypoCorrection &getNextCorrection();
+
+  /// \brief Get the last correction returned by getNextCorrection().
+  TypoCorrection &getCurrentCorrection() {

Since the TypoCorrections are now intended to be reused, it would seem wise
to return them either by value or by const reference.

On Mon, Jul 14, 2014 at 4:55 PM, Kaelyn Takata <rikka at google.com> wrote:

>
> Two additional methods are provided: one to return the current
> correction (the last correction returned by getNextCorrection), and one
> to "reset" the state so that getNextCorrection will return the previous
> corrections before returning any new corrections.
>
> Also ensure that all TypoCorrections have valid source ranges.
> ---
>  include/clang/Sema/SemaInternal.h   | 31 ++++++++++++++++++++++++++-----
>  include/clang/Sema/TypoCorrection.h |  2 +-
>  lib/Sema/SemaLookup.cpp             | 16 ++++++++++++----
>  3 files changed, 39 insertions(+), 10 deletions(-)
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140725/828b77a2/attachment.html>


More information about the cfe-commits mailing list