[PATCH v3 3/9] Pass around CorrectionCandidateCallbacks as unique_ptrs so TypoCorrectionConsumer can keep the callback around as long as needed.

Richard Smith richard at metafoo.co.uk
Fri Jul 25 13:58:53 PDT 2014


Looks fine as a mechanical change; if the final approach to ownership needs
this, then LGTM.


2014-07-14 16:55 GMT-07:00 Kaelyn Takata <rikka at google.com>:

> ---
>  include/clang/Parse/Parser.h      |  5 ++--
>  include/clang/Sema/Sema.h         | 27 +++++++++----------
>  include/clang/Sema/SemaInternal.h | 18 ++++++-------
>  lib/Parse/ParseExpr.cpp           |  8 +++---
>  lib/Parse/ParseStmt.cpp           |  6 ++---
>  lib/Parse/ParseTentative.cpp      |  8 +++---
>  lib/Parse/Parser.cpp              |  8 +++---
>  lib/Sema/SemaCXXScopeSpec.cpp     |  9 +++----
>  lib/Sema/SemaDecl.cpp             | 57
> +++++++++++++++++++--------------------
>  lib/Sema/SemaDeclCXX.cpp          | 27 ++++++++++---------
>  lib/Sema/SemaDeclObjC.cpp         | 21 +++++++--------
>  lib/Sema/SemaExpr.cpp             | 37 ++++++++++++-------------
>  lib/Sema/SemaExprMember.cpp       | 15 +++++------
>  lib/Sema/SemaExprObjC.cpp         | 18 ++++++-------
>  lib/Sema/SemaInit.cpp             |  4 +--
>  lib/Sema/SemaLambda.cpp           |  4 +--
>  lib/Sema/SemaLookup.cpp           | 27 +++++++++++--------
>  lib/Sema/SemaOpenMP.cpp           |  7 +++--
>  lib/Sema/SemaOverload.cpp         | 23 +++++++++-------
>  lib/Sema/SemaTemplate.cpp         | 17 ++++++------
>  lib/Sema/SemaTemplateVariadic.cpp |  8 +++---
>  21 files changed, 179 insertions(+), 175 deletions(-)
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140725/9714cddd/attachment.html>


More information about the cfe-commits mailing list