[patch] Don't assert when mov'ing into segment registers in inline asm

Nico Weber thakis at chromium.org
Thu Jul 17 12:31:28 PDT 2014


Some more background: This list is used to check the clobber list, and
since ms inline asm doesn't have explicit clobber
lists, AsmParser::parseMSInlineAsm() adds all touched registers to the
clobber list.

This change would also permit the segment registers in the clobber lists
for gcc registers. A different fix would be to change parseMSInlineAsm() to
not add segment registers as clobbers. rnk tells me he likes that approach
better, so I'll do that instead.


On Thu, Jul 17, 2014 at 12:06 PM, Eric Christopher <echristo at gmail.com>
wrote:

> Seems reasonable.
>
> -eric
>
> On Thu, Jul 17, 2014 at 11:55 AM, Nico Weber <thakis at chromium.org> wrote:
> > Hi,
> >
> > the attached patch fixes PR20343 by adding the segment registers to the
> x86
> > register list in Targets.cpp.
> >
> > Nico
> >
> > _______________________________________________
> > cfe-commits mailing list
> > cfe-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140717/49e60cac/attachment.html>


More information about the cfe-commits mailing list