[PATCH] [RFC] Introduce support for multiple sanitizer blacklists (Clang side).

[Peter Collingbourne]

================
Comment at: include/clang/Driver/SanitizerArgs.h:12
@@ -11,2 +11,3 @@
 
+#include "llvm/ADT/StringRef.h"
 #include "llvm/Option/Arg.h"
----------------
Alexey Samsonov wrote:
> You may include clang/Basic/LLVM.h and use plain StringRef instead of llvm::StringRef.
Done.

================
Comment at: lib/CodeGen/BackendUtil.cpp:592
@@ -589,1 +591,3 @@
 
+std::unique_ptr<SpecialCaseList> clang::CreateSpecialCaseList(const CodeGenOptions &CGOpts) {
+  auto SCL = llvm::make_unique<SpecialCaseList>();
----------------
Alexey Samsonov wrote:
> See my comment in LLVM part - this file doesn't look like the right place for this function.
I was imagining that we could add things like support for ad hoc entries here if we needed it.

================
Comment at: lib/Driver/SanitizerArgs.cpp:128
@@ +127,3 @@
+    Arg->claim();
+    if (llvm::sys::fs::exists(Arg->getValue())) {
+      addBlacklistFile(D, Arg->getValue());
----------------
Alexey Samsonov wrote:
> nit: remove {} for if- and else- clauses for consistency.
Done.

http://reviews.llvm.org/D4547