[PATCH] Suggest automated replacements of C-style casts with C++ casts.

Daniel Jasper djasper at google.com
Mon Jul 14 00:06:26 PDT 2014


Looks good. Nice!

================
Comment at: clang-tidy/google/AvoidCStyleCastsCheck.cpp:86
@@ +85,3 @@
+    diag_builder << ("Use " + CastType + ".").str();
+    if (ParenRange.getBegin().isFileID() && ParenRange.getEnd().isFileID()) {
+      diag_builder << FixItHint::CreateReplacement(
----------------
I'd probably prefer "if (!ParenRange ...) return".

http://reviews.llvm.org/D4478






More information about the cfe-commits mailing list