[PATCH, PowerPC] ABI fixes / improvements for powerpc64-linux
Ulrich.Weigand at de.ibm.com
Thu Jul 10 08:23:39 PDT 2014
Hal Finkel <hfinkel at anl.gov> wrote on 10.07.2014 01:14:22:
> To be clear, you can commit the patches -- you won't be making
> anything worse in practice, and you'll fix the gcc incompatibility
> However, it is not clear to me that the current code for
> handling alignment of the byval parameters, or anything else, will
> create the necessary copies. Can you please make sure that works
Indeed. It seems the TargetInfo code should set the "Realign" flag
on the Indirect ABI node if the type alignment is larger than the
alignment in the parameter area; this is done on other platforms
but not on PowerPC right now.
This will cause code to be generated that realigns the incoming
parameter. I'll add that flag (and test cases) to the patch as
I commit it ...
> Regarding the new ABI, we should have an ongoing discussion.
Sure. I'll try to post my current patches soon (even if they're
not fully complete) to have a better basis for discussion ...
More information about the cfe-commits