[PATCH] [clang-tidy] Add a checker for implicit bool conversion of a bool*.

Daniel Jasper djasper at google.com
Thu Jul 10 07:18:23 PDT 2014


I think there are still many corner cases that can be improved, but this is good as a first version.

================
Comment at: test/clang-tidy/misc-bool-pointer-implicit-conversion.cpp:8
@@ +7,3 @@
+
+#define CHECK if (b || F())
+
----------------
Can you name this something other than CHECK? I find this a bit confusing with CHECK-MESSAGES and CHECK-FIXES..

Also consider moving this down so it is close to its invocation.

http://reviews.llvm.org/D4458






More information about the cfe-commits mailing list