[PATCH] Avoid definining more GCC specific predefined macros in clang-cl

Ehsan Akhgari ehsan.akhgari at gmail.com
Wed Jul 9 10:19:39 PDT 2014


On Wed, Jul 9, 2014 at 12:06 PM, Alp Toker <alp at nuanti.com> wrote:

>
> On 09/07/2014 18:48, David Majnemer wrote:
>
>> I don't think that MSVC compat is the right predicate here, this has more
>> to do with targeting the msvc environment.
>>
>
> We're planning go over these soon and switch them to a more appropriate
> flag like GCCCompat, which will generally be set to !MSVCCompat


Yes please!


> -- so Ehsan's approach is fine for now and easy to move to the new scheme
> when needed.
>

So should I proceed with the patch as is?

--
Ehsan
<http://ehsanakhgari.org/>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140709/a5a85b79/attachment.html>


More information about the cfe-commits mailing list