[PATCH] Add support for nested blocks in Microsoft inline assembly

Ehsan Akhgari ehsan.akhgari at gmail.com
Sat Jul 5 14:04:32 PDT 2014


On Sat, Jul 5, 2014 at 4:57 PM, David Majnemer <david.majnemer at gmail.com>
wrote:

> Awesome!
>
> Does this also glue together consecutive __asm statements that aren't in a
> block?
>
> Like:
> __asm mov 1, eax
> __asm add eax, ecx
>
> That should turn into a single inline assembly IR instruction.
>

No, this patch doesn't change anything about single __asm statements.  I
can do that too if you want (it requires modifying the logic of the line
end detection) but I prefer to do that separately if that's OK.

Cheers,
Ehsan


> On Saturday, July 5, 2014, Ehsan Akhgari <ehsan.akhgari at gmail.com> wrote:
>
>> Hi majnemer,
>>
>> This fixes http://llvm.org/PR20204.
>>
>> http://reviews.llvm.org/D4399
>>
>> Files:
>>   lib/Parse/ParseStmtAsm.cpp
>>   test/CodeGen/ms-inline-asm-64.c
>>   test/CodeGen/ms-inline-asm.c
>>   test/Parser/ms-inline-asm-nested-braces.c
>>   test/Parser/ms-inline-asm.c
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140705/089e5e48/attachment.html>


More information about the cfe-commits mailing list