[PATCH] [libcxxabi] Add a cmake build system.

Alexey Samsonov vonosmas at gmail.com
Tue Jul 1 16:28:53 PDT 2014


I don't really understand why (most of) compiler flags are set up in the root CMakeLists.txt, while the link flags are set up in src/CMakeLists.txt, but probably that's not a big deal.

Thanks for working on this!

================
Comment at: src/CMakeLists.txt:39
@@ +38,3 @@
+# Setup flags.
+append_if(compile_flags LIBCXXABI_HAS_FPIC_FLAG -fPIC)
+append_if(link_flags LIBCXXABI_HAS_NODEFAULTLIBS_FLAG -nodefaultlibs)
----------------
Why not use "set" here?

================
Comment at: src/CMakeLists.txt:57
@@ +56,3 @@
+
+string(REPLACE ";" " " link_flags "${link_flags}")
+
----------------
Do you need to do the same for compile_flags?

http://reviews.llvm.org/D4359






More information about the cfe-commits mailing list