r212092 - Enable test/CodeGen/indirect-goto.c in 64b for local arrays

Reid Kleckner rnk at google.com
Tue Jul 1 11:37:48 PDT 2014


On Mon, Jun 30, 2014 at 10:10 PM, Gerolf Hoflehner <ghoflehner at apple.com>
wrote:

> Modified: cfe/trunk/test/CodeGen/indirect-goto.c
> URL:
> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/indirect-goto.c?rev=212092&r1=212091&r2=212092&view=diff
>
> ==============================================================================
> --- cfe/trunk/test/CodeGen/indirect-goto.c (original)
> +++ cfe/trunk/test/CodeGen/indirect-goto.c Tue Jul  1 00:10:06 2014
> @@ -1,5 +1,4 @@
> -// RUN: %clang_cc1 -triple i386-unknown-unknown -O3 -emit-llvm -o - %s
> -// DISABLED: %clang_cc1 -triple i386-unknown-unknown -O3 -emit-llvm -o -
> %s | grep "ret i32 2520"
> +// RUN: %clang_cc1 -triple x86_64-unknown-unknown -O3 -emit-llvm -o - %s
> | grep "ret i32 2520"
>

Other issues aside, this a test for all of LLVM's optimizers, and not for
clang.  We don't test LLVM's optimizers from Clang.  Please reduce this to
an LLVM IR test and check it in there.  Even in LLVM, we rarely write full
-O3 integration tests.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140701/ad501c8f/attachment.html>


More information about the cfe-commits mailing list