[PATCH] Downgrade the error about nested name specifiers when building with Microsoft extensions
alp at nuanti.com
Mon Jun 30 12:52:22 PDT 2014
The patch is neat though, certainly let's reconsider pulling it in if
more requests come in for this quirk in future.
On 30/06/2014 22:34, Reid Kleckner wrote:
> Yeah, let's drop it. Sorry for the runaround.
> On Mon, Jun 30, 2014 at 8:26 AM, Ehsan Akhgari
> <ehsan.akhgari at gmail.com <mailto:ehsan.akhgari at gmail.com>> wrote:
> We hit this error in our code and I have since fixed the code on
> our side. I'm not aware of any system headers or generate code
> that hits this.
> Based on that, should we can this patch?
> On Sat, Jun 28, 2014 at 2:07 PM, Reid Kleckner <rnk at google.com
> <mailto:rnk at google.com>> wrote:
> I'd echo what David said, but otherwise, this seems fine.
> Comment at: lib/Sema/SemaDecl.cpp:3290
> @@ +3289,3 @@
> + Diag(SS.getBeginLoc(),
> + getLangOpts().MicrosoftExt ?
> + diag::ext_standalone_class_nested_name_specifier :
> We use LangOpts.MSVCCompat to control these language bending
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
the browser experts
More information about the cfe-commits