[PATCH] Downgrade the error about nested name specifiers when building with Microsoft extensions

Reid Kleckner rnk at google.com
Mon Jun 30 12:34:29 PDT 2014


Yeah, let's drop it.  Sorry for the runaround.


On Mon, Jun 30, 2014 at 8:26 AM, Ehsan Akhgari <ehsan.akhgari at gmail.com>
wrote:

> We hit this error in our code and I have since fixed the code on our
> side.  I'm not aware of any system headers or generate code that hits this.
>
> Based on that, should we can this patch?
>
> --
> Ehsan
> <http://ehsanakhgari.org/>
>
>
> On Sat, Jun 28, 2014 at 2:07 PM, Reid Kleckner <rnk at google.com> wrote:
>
>> I'd echo what David said, but otherwise, this seems fine.
>>
>> ================
>> Comment at: lib/Sema/SemaDecl.cpp:3290
>> @@ +3289,3 @@
>> +    Diag(SS.getBeginLoc(),
>> +         getLangOpts().MicrosoftExt ?
>> +           diag::ext_standalone_class_nested_name_specifier :
>> ----------------
>> We use LangOpts.MSVCCompat to control these language bending extensions.
>>
>> http://reviews.llvm.org/D4333
>>
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140630/ad2b1374/attachment.html>


More information about the cfe-commits mailing list