[PATCH] Silence the implicit signed/unsigned conversion warning.

Richard Smith richard at metafoo.co.uk
Thu Jun 26 11:57:39 PDT 2014


================
Comment at: src/Unwind/Unwind-EHABI.cpp:213
@@ -211,3 +212,3 @@
 uint32_t RegisterRange(uint8_t start, uint8_t count_minus_one) {
-  return (start << 16) | (count_minus_one + 1);
+  return ((uint32_t)start << 16) | ((uint32_t)count_minus_one + 1);
 }
----------------
Nico Weber wrote:
> Huh, your compiler warns when widening a unsigned byte to an unsigned int? Interesting.
Both subexpressions of the `|` used to be of type `signed int`; the warning will be for converting the result of the `|` to `unsigned`.

http://reviews.llvm.org/D4315






More information about the cfe-commits mailing list