r211604 - Use lowercase windows.h for mingw cross compilation.

Aaron Ballman aaron at aaronballman.com
Wed Jun 25 04:45:46 PDT 2014

On Tue, Jun 24, 2014 at 9:36 PM, Alp Toker <alp at nuanti.com> wrote:
> On 25/06/2014 00:06, Zachary Turner wrote:
>> Couldn't LLVM expose a registry interface on Windows and then the
>> front-end could conditionally include this header on Windows?  Other users
>> of LLVM might wish to use the registry too.
> Using the registry in WindowsToolChain is an unfortunate/isolated toolchain
> hack that needs to be kept around for the time being.
> It's not a facility we want to propagate, abstract or normalize the usage of
> in LLVM.

I don't believe there's been any community discussion of that
viewpoint, so that may be a bit premature of statement. I can think of
instances where the frontend could benefit from registry usage on
Windows in addition to the usages we already have.

That being said, it still doesn't affect this particular patch. So if
we want to discuss a blanket statement about LLVM developer policy
like this, we should probably do it in a more properly-titled thread.


More information about the cfe-commits mailing list