[PATCH] MS ABI: Propagate class-level DLL attributes to class template specialization bases (PR11170)

Hans Wennborg hans at chromium.org
Tue Jun 24 10:01:13 PDT 2014

On Mon, Jun 23, 2014 at 6:06 PM, David Majnemer
<david.majnemer at gmail.com> wrote:
> ================
> Comment at: lib/Sema/SemaDeclCXX.cpp:1299
> @@ -1298,1 +1298,3 @@
> +static void propagateDLLAttrToBaseClassTemplate(
> +    Sema &S, CXXRecordDecl *Class, Attr *ClassAttr,
> ----------------
> Can this function get some comments?  I don't understand //why// it raises diagnostics when it does or why it is checking for `TSK_Undeclared`.

Sorry about that. Yes, I'll add some comments about what's going on here.

More information about the cfe-commits mailing list