r211420 - Driver: enhance MSC version compatibility

Aaron Ballman aaron at aaronballman.com
Tue Jun 24 07:31:30 PDT 2014

On Tue, Jun 24, 2014 at 10:28 AM, Eric Christopher <echristo at gmail.com> wrote:
> On Mon, Jun 23, 2014 at 1:02 PM, Reid Kleckner <rnk at google.com> wrote:
>> On Sat, Jun 21, 2014 at 11:32 AM, Alp Toker <alp at nuanti.com> wrote:
>>> Please split out and name the new dotted form something like
>>> "-msc-full-version" to avoid ambiguity.
>> I was inclinded to overload the option because it means we don't have to
>> diagnose this case: -fmsc-version -fmsc-full-version=17.00.0.  We just do
>> the obvious thing of "last one always wins".  Diagnosing the conflict isn't
>> too hard, though, so let's just split the options and do exactly that in the
>> driver.
> I'm inclined to agree with this. We could also even deprecate the
> original option and have the new option have exactly the semantics we
> want. Aaron?

If we deprecate the original option and warn when the options are
combined in the meantime, then I'd be okay with splitting the options.


More information about the cfe-commits mailing list