[PATCH] Warn on use of vector initializers in ARM BE mode

[Alp Toker]

Yes, I'm happy. 

LGTM

On 20 June 2014 10:20:04 EEST, James Molloy <james.molloy at arm.com> wrote:
>Thanks Renato!
>
>Alp, are you happy too?
>
>Cheers,
>
>James
>
>> -----Original Message-----
>> From: Renato Golin [mailto:renato.golin at linaro.org]
>> Sent: 19 June 2014 17:08
>> To: James Molloy
>> Cc: Tim Northover; Clang Commits
>> Subject: Re: [PATCH] Warn on use of vector initializers in ARM BE
>mode
>> 
>> LGTM
>> 
>> On 19 June 2014 16:27, James Molloy <james.molloy at arm.com> wrote:
>> > Hi chaps,
>> >
>> > So I've edited the patch again, taking into account Alp's comments.
>> >
>> > The behaviour of the patch is that now, it will warn when
>encountering
>> an initializer on a NEON type (not just any ext_vector) in big endian
>> mode.
>> >
>> > I think the impact of this is now sufficiently small that there
>should
>> be no complaints, and it could save users a lot of anguish.
>> >
>> > Cheers,
>> >
>> > James
>> >
>> >> -----Original Message-----
>> >> From: Tim Northover [mailto:t.p.northover at gmail.com]
>> >> Sent: 19 June 2014 14:53
>> >> To: Renato Golin
>> >> Cc: James Molloy; Clang Commits
>> >> Subject: Re: [PATCH] Warn on use of vector initializers in ARM BE
>mode
>> >>
>> >> > Tim, do you have any use case for the lack of the header, or is
>it
>> >> > just theoretical?
>> >>
>> >> Nah, it's purely theoretical. I don't really object to the patch
>> >> either, so go ahead if people think it's a good idea.
>> >>
>> >> Cheers.
>> >>
>> >> Tim.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140620/d4a168ac/attachment.html>